lkml.org 
[lkml]   [2016]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 1/5] block-cciss: Use memdup_user() rather than duplicating its implementation
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Wed, 17 Aug 2016 22:10:29 +0200

    * Reuse existing functionality from memdup_user() instead of keeping
    duplicate source code.

    This issue was detected by using the Coccinelle software.

    * Return directly if this copy operation failed.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/block/cciss.c | 12 +++---------
    1 file changed, 3 insertions(+), 9 deletions(-)

    diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
    index db9d6bb..e044342 100644
    --- a/drivers/block/cciss.c
    +++ b/drivers/block/cciss.c
    @@ -1587,15 +1587,9 @@ static int cciss_bigpassthru(ctlr_info_t *h, void __user *argp)
    return -EINVAL;
    if (!capable(CAP_SYS_RAWIO))
    return -EPERM;
    - ioc = kmalloc(sizeof(*ioc), GFP_KERNEL);
    - if (!ioc) {
    - status = -ENOMEM;
    - goto cleanup1;
    - }
    - if (copy_from_user(ioc, argp, sizeof(*ioc))) {
    - status = -EFAULT;
    - goto cleanup1;
    - }
    + ioc = memdup_user(argp, sizeof(*ioc));
    + if (IS_ERR(ioc))
    + return PTR_ERR(ioc);
    if ((ioc->buf_size < 1) &&
    (ioc->Request.Type.Direction != XFER_NONE)) {
    status = -EINVAL;
    --
    2.9.3
    \
     
     \ /
      Last update: 2016-09-17 09:57    [W:4.134 / U:0.532 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site