lkml.org 
[lkml]   [2016]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 1/2] GPU-DRM-Savage: Use memdup_user() rather than duplicating
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 18 Aug 2016 18:12:03 +0200

    Reuse existing functionality from memdup_user() instead of keeping
    duplicate source code.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/gpu/drm/savage/savage_state.c | 12 +++---------
    1 file changed, 3 insertions(+), 9 deletions(-)

    diff --git a/drivers/gpu/drm/savage/savage_state.c b/drivers/gpu/drm/savage/savage_state.c
    index c01ad0a..3dc0d8f 100644
    --- a/drivers/gpu/drm/savage/savage_state.c
    +++ b/drivers/gpu/drm/savage/savage_state.c
    @@ -1001,15 +1001,9 @@ int savage_bci_cmdbuf(struct drm_device *dev, void *data, struct drm_file *file_
    cmdbuf->cmd_addr = kcmd_addr;
    }
    if (cmdbuf->vb_size) {
    - kvb_addr = kmalloc(cmdbuf->vb_size, GFP_KERNEL);
    - if (kvb_addr == NULL) {
    - ret = -ENOMEM;
    - goto done;
    - }
    -
    - if (copy_from_user(kvb_addr, cmdbuf->vb_addr,
    - cmdbuf->vb_size)) {
    - ret = -EFAULT;
    + kvb_addr = memdup_user(cmdbuf->vb_addr, cmdbuf->vb_size);
    + if (IS_ERR(kvb_addr)) {
    + ret = PTR_ERR(kvb_addr);
    goto done;
    }
    cmdbuf->vb_addr = kvb_addr;
    --
    2.9.3
    \
     
     \ /
      Last update: 2016-09-17 09:57    [W:4.400 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site