lkml.org 
[lkml]   [2016]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 1/4] perf/core: check return value of perf_event_read IPI
> > The call to smp_call_function_single in perf_event_read() may fail and,
> > when it does, its error value is the one to return.
> >
> Please also describe the symptoms of the bug - under what circumstances may the
> smp-call fail and how does the user notice?
>
> Thanks,
>
> Ingo
generic_exec_single only fails if cpu is invalid or not online, which
currently is not supposed to happen. Since perf_event_read's error is
not checked, I guess a WARN_ON_ONCE is needed. I'll post a rebased
version with this change.

Thanks,
David

\
 
 \ /
  Last update: 2016-09-17 09:57    [W:3.345 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site