Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Tue, 16 Aug 2016 20:06:35 +0200 | Subject | Re: [PATCH v2] ARM: Add missing newline terminators to kernel messages |
| |
Hi Joe,
On Tue, Aug 16, 2016 at 8:01 PM, Joe Perches <joe@perches.com> wrote: > On Tue, 2016-08-16 at 19:50 +0200, Geert Uytterhoeven wrote: >> On Tue, Aug 16, 2016 at 7:08 PM, Joe Perches <joe@perches.com> wrote: >> > On Tue, 2016-08-16 at 15:40 +0200, Geert Uytterhoeven wrote: >> > > Before commit 874f9c7da9a4acbc ("printk: create pr_<level> >> > > functions"), >> > > pr_*() calls without a trailing newline characters would be >> > > printed with >> > > a newline character appended, both on the console and in the >> > > output of >> > > the dmesg command. >> > Hey Geert. >> > >> > This doesn't apply to -next as the pr_notice/pr_cont below is >> > properly changed to a single pr_notice. >> In which -next? >> >> Not in next-20160816, where the patch applies cleanly. >> Also not in arm/for-next. > > My mistake, I was in the wrong directory. > It doesn't apply to Linus' tree.
It's meant for the arm tree.
> Still, it'd be slightly nicer to use a single > pr_notice than the pr_notice/pr_cont.
Indeed. The code was recently changed to split the message, hence my v2...
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |