lkml.org 
[lkml]   [2016]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] pnp: isapnp: make core more explicitly non-modular
Date
On Monday, August 15, 2016 06:42:33 PM Paul Gortmaker wrote:
> The Makefile currently controlling compilation of this code is:
>
> obj-y += pnp.o
> pnp-y := core.o compat.o
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the couple traces of modular infrastructure use, so that
> when reading the driver there is no doubt it is builtin-only.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> We don't replace module.h with init.h since the file already has that.
> But we do add moduleparam.h since the file does use module_param().
>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

I'll queue up this one for v4.9, thanks!

Best,
Rafael

\
 
 \ /
  Last update: 2016-09-17 09:57    [W:0.029 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site