lkml.org 
[lkml]   [2016]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/8] Remove deprecated workqueue interface users
On Sat, Aug 13, 2016 at 09:41:21PM +0530, Bhaktipriya Shridhar wrote:
> This patch set removes the instances of deprecated
> create_singlethread_workqueues in drivers/power by making the appropriate
> conversions.
>
> Bhaktipriya Shridhar (8):
> power: abx500_chargalg: Remove deprecated create_singlethread_workqueue
> power: ab8500_btemp: Remove deprecated create_singlethread_workqueue
> power: pm2301_charger: Remove deprecated create_singlethread_workqueue
> power: intel_mid_battery: Remove deprecated create_singlethread_workqueue
> power: ab8500_charger: Remove deprecated create_singlethread_workqueue
> power: ipaq_micro_battery: Remove deprecated create_singlethread_workqueue
> power: ab8500_fg: Remove deprecated create_singlethread_workqueue
> power: ds2760_battery: Remove deprecated create_singlethread_workqueue

Patches look good to me. I'm a bit curious about WQ_MEM_RECLAIM part
tho. I suppose the reasoning is that as the hardware in question is
involved in battery management which may be time critical,
WQ_MEM_RECLAIM is added to ensure (timely) forward progress under
memory pressure, right? It'd be great if someone who's more familiar
with these hardware can confirm whether this is actually necessary.

Oh, it'd also be nice to put the target subsystem in the subject of
the patchset - e.g. "[PATCH 0/8] power: Remove..."

Thanks.

--
tejun

\
 
 \ /
  Last update: 2016-09-17 09:57    [W:0.735 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site