lkml.org 
[lkml]   [2016]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/3] sas: provide stub implementations for scsi_is_sas_phy and sas_get_address
From
Date
On Mon, 2016-08-15 at 17:12 +0200, Johannes Thumshirn wrote:
> +static inline u64 sas_get_address(struct scsi_device *sdev)
> +{
> + return 0;
> +}

To be honest, we don't want this. We do want the code to fail to
compile if you ever use sas_get_address where you shouldn't because the
code will be incorrect at that point. If we could return an error,
fine, but we just return the address.

James


\
 
 \ /
  Last update: 2016-09-17 09:56    [W:0.096 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site