lkml.org 
[lkml]   [2016]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/3] Input: psmouse: Remove deprecated create_singletheread_workqueue
    alloc_ordered_workqueue replaces the deprecated
    create_singlethread_workqueue.

    There are multiple work items on the work queue viz
    &priv->dev3_register_work, &priv->recalib_wq, &psmouse->resync_work,
    which require execution ordering. Hence, an ordered workqueue has been
    used.

    The workqueue is not being used on a memory reclaim path.
    Hence, WQ_MEM_RECLAIM has not been set.

    Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
    ---
    drivers/input/mouse/psmouse-base.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/input/mouse/psmouse-base.c b/drivers/input/mouse/psmouse-base.c
    index 5784e20..fb4b185 100644
    --- a/drivers/input/mouse/psmouse-base.c
    +++ b/drivers/input/mouse/psmouse-base.c
    @@ -1916,7 +1916,7 @@ static int __init psmouse_init(void)
    synaptics_module_init();
    hgpk_module_init();

    - kpsmoused_wq = create_singlethread_workqueue("kpsmoused");
    + kpsmoused_wq = alloc_ordered_workqueue("kpsmoused", 0);
    if (!kpsmoused_wq) {
    pr_err("failed to create kpsmoused workqueue\n");
    return -ENOMEM;
    --
    2.1.4
    \
     
     \ /
      Last update: 2016-09-17 09:56    [W:3.029 / U:0.632 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site