lkml.org 
[lkml]   [2016]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 25/29] bonding: set carrier off for devices created through netlink
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Beniamino Galvani <bgalvani@redhat.com>

    [ Upstream commit 005db31d5f5f7c31cfdc43505d77eb3ca5cf8ec6 ]

    Commit e826eafa65c6 ("bonding: Call netif_carrier_off after
    register_netdevice") moved netif_carrier_off() from bond_init() to
    bond_create(), but the latter is called only for initial default
    devices and ones created through sysfs:

    $ modprobe bonding
    $ echo +bond1 > /sys/class/net/bonding_masters
    $ ip link add bond2 type bond
    $ grep "MII Status" /proc/net/bonding/*
    /proc/net/bonding/bond0:MII Status: down
    /proc/net/bonding/bond1:MII Status: down
    /proc/net/bonding/bond2:MII Status: up

    Ensure that carrier is initially off also for devices created through
    netlink.

    Signed-off-by: Beniamino Galvani <bgalvani@redhat.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/bonding/bond_netlink.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    --- a/drivers/net/bonding/bond_netlink.c
    +++ b/drivers/net/bonding/bond_netlink.c
    @@ -360,7 +360,11 @@ static int bond_newlink(struct net *src_
    if (err < 0)
    return err;

    - return register_netdevice(bond_dev);
    + err = register_netdevice(bond_dev);
    +
    + netif_carrier_off(bond_dev);
    +
    + return err;
    }

    static size_t bond_get_size(const struct net_device *bond_dev)

    \
     
     \ /
      Last update: 2016-09-17 09:56    [W:4.265 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site