lkml.org 
[lkml]   [2016]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] CodingStyle: Clarify and complete chapter 7
On Mon, 25 Jul 2016 14:29:06 +0200
Jean Delvare <jdelvare@suse.de> wrote:

> Chapter 7 (Centralized exiting of functions) of the coding style
> documentation is unclear at times, and lacks some information (such
> as the possibility to indent labels with a single space.) Clarify and
> complete it.

OK, I've applied this (finally) to the docs tree, sorry for sitting on it
for so long. One question, though...

> A common type of bug to be aware of is "one err bugs" which look like this:
>
> - err:
> + err:
> kfree(foo->bar);
> kfree(foo);
> return ret;
>
> The bug in this code is that on some exit paths "foo" is NULL. Normally the

...except that kfree() can handle null pointers just fine, so this isn't
actually a bug, right? Someday when somebody has time it would be good to
come up with a better example.

Thanks,

jon

\
 
 \ /
  Last update: 2016-09-17 09:56    [W:0.058 / U:0.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site