lkml.org 
[lkml]   [2016]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 22/94] net/mlx4_core: Fix access to uninitialized index
    3.2.82-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Tariq Toukan <tariqt@mellanox.com>

    commit 2bb07e155bb3e0c722c806723f737cf8020961ef upstream.

    Prevent using uninitialized or negative index when handling
    steering entries.

    Fixes: b12d93d63c32 ('mlx4: Add support for promiscuous mode in the new steering model.')
    Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    [bwh: Backported to 3.2: adjust context]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/net/ethernet/mellanox/mlx4/mcg.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/net/ethernet/mellanox/mlx4/mcg.c
    +++ b/drivers/net/ethernet/mellanox/mlx4/mcg.c
    @@ -615,7 +615,7 @@ int mlx4_qp_attach_common(struct mlx4_de
    struct mlx4_mgm *mgm;
    u32 members_count;
    u16 hash;
    - int index, prev;
    + int index = -1, prev;
    int link = 0;
    int i;
    int err;
    @@ -693,7 +693,7 @@ int mlx4_qp_attach_common(struct mlx4_de
    goto out;

    out:
    - if (prot == MLX4_PROT_ETH) {
    + if (prot == MLX4_PROT_ETH && index != -1) {
    /* manage the steering entry for promisc mode */
    if (new_entry)
    new_steering_entry(dev, 0, port, steer, index, qp->qpn);
    \
     
     \ /
      Last update: 2016-09-17 09:56    [W:4.138 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site