lkml.org 
[lkml]   [2016]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 028/305] alpha/PCI: Call iomem_is_exclusive() for IORESOURCE_MEM, but not IORESOURCE_IO
    3.16.37-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Bjorn Helgaas <bhelgaas@google.com>

    commit c20e128030caf0537d5e906753eac1c28fefdb75 upstream.

    The alpha pci_mmap_resource() is used for both IORESOURCE_MEM and
    IORESOURCE_IO resources, but iomem_is_exclusive() is only applicable for
    IORESOURCE_MEM.

    Call iomem_is_exclusive() only for IORESOURCE_MEM resources, and do it
    earlier to match the generic version of pci_mmap_resource().

    Fixes: 10a0ef39fbd1 ("PCI/alpha: pci sysfs resources")
    Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
    CC: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    arch/alpha/kernel/pci-sysfs.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/arch/alpha/kernel/pci-sysfs.c
    +++ b/arch/alpha/kernel/pci-sysfs.c
    @@ -77,10 +77,10 @@ static int pci_mmap_resource(struct kobj
    if (i >= PCI_ROM_RESOURCE)
    return -ENODEV;

    - if (!__pci_mmap_fits(pdev, i, vma, sparse))
    + if (res->flags & IORESOURCE_MEM && iomem_is_exclusive(res->start))
    return -EINVAL;

    - if (iomem_is_exclusive(res->start))
    + if (!__pci_mmap_fits(pdev, i, vma, sparse))
    return -EINVAL;

    pcibios_resource_to_bus(pdev->bus, &bar, res);
    \
     
     \ /
      Last update: 2016-09-17 09:56    [W:4.293 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site