lkml.org 
[lkml]   [2016]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 171/305] HID: elo: kill not flush the work
    3.16.37-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Oliver Neukum <oneukum@suse.com>

    commit ed596a4a88bd161f868ccba078557ee7ede8a6ef upstream.

    Flushing a work that reschedules itself is not a sensible operation. It needs
    to be killed. Failure to do so leads to a kernel panic in the timer code.

    Signed-off-by: Oliver Neukum <ONeukum@suse.com>
    Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/hid/hid-elo.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/hid/hid-elo.c
    +++ b/drivers/hid/hid-elo.c
    @@ -259,7 +259,7 @@ static void elo_remove(struct hid_device
    struct elo_priv *priv = hid_get_drvdata(hdev);

    hid_hw_stop(hdev);
    - flush_workqueue(wq);
    + cancel_delayed_work_sync(&priv->work);
    kfree(priv);
    }

    \
     
     \ /
      Last update: 2016-09-17 09:56    [W:4.183 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site