lkml.org 
[lkml]   [2016]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 059/305] USB: serial: mxuport: fix use-after-free in probe error path
    3.16.37-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <johan@kernel.org>

    commit 9e45284984096314994777f27e1446dfbfd2f0d7 upstream.

    The interface read and event URBs are submitted in attach, but were
    never explicitly unlinked by the driver. Instead the URBs would have
    been killed by usb-serial core on disconnect.

    In case of a late probe error (e.g. due to failed minor allocation),
    disconnect is never called and we could end up with active URBs for an
    unbound interface. This in turn could lead to deallocated memory being
    dereferenced in the completion callbacks.

    Fixes: ee467a1f2066 ("USB: serial: add Moxa UPORT 12XX/14XX/16XX
    driver")
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/usb/serial/mxuport.c | 10 ++++++++++
    1 file changed, 10 insertions(+)

    --- a/drivers/usb/serial/mxuport.c
    +++ b/drivers/usb/serial/mxuport.c
    @@ -1263,6 +1263,15 @@ static int mxuport_attach(struct usb_ser
    return 0;
    }

    +static void mxuport_release(struct usb_serial *serial)
    +{
    + struct usb_serial_port *port0 = serial->port[0];
    + struct usb_serial_port *port1 = serial->port[1];
    +
    + usb_serial_generic_close(port1);
    + usb_serial_generic_close(port0);
    +}
    +
    static int mxuport_open(struct tty_struct *tty, struct usb_serial_port *port)
    {
    struct mxuport_port *mxport = usb_get_serial_port_data(port);
    @@ -1365,6 +1374,7 @@ static struct usb_serial_driver mxuport_
    .probe = mxuport_probe,
    .port_probe = mxuport_port_probe,
    .attach = mxuport_attach,
    + .release = mxuport_release,
    .calc_num_ports = mxuport_calc_num_ports,
    .open = mxuport_open,
    .close = mxuport_close,
    \
     
     \ /
      Last update: 2016-09-17 09:56    [W:2.769 / U:0.716 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site