lkml.org 
[lkml]   [2016]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: staging: ks7010: Replace three printk() calls by pr_err()
    From
    Date
    > Really now, this is basic fixes and cleanups,

    I agree to this view to some degree.


    > you have been asked many times in the past to move on beyond these,

    It is more useful when more severe bugs or bigger software improvements can be found.
    Which source code clean-ups are picked better up by other contributors?


    > as you often times seem to end up wasting lots of people's times
    > as they attempt to help you.

    It can take a bit more time occasionally to achieve the desired consensus.


    > Personally, I'm long past wishing to help you out here, sorry.

    Other contributors will eventually continue the clarification of remaining
    open issues in the source file "ks7010_sdio.c".


    > I'll take "correct" patches, but that's it. No discussion of them, no
    > arguing over theoreticals, and no telling you what I might, or might
    > not, want to see done in the future, sorry.

    I became aware about software development possibilities which can also
    matter here.
    Yesterday Julia Lawall informed me about a presentation on the topic
    "Refactor strings – make everyone happy" by Wolfram Sang on 2016-07-14.

    Is such a software evolution also interesting and acceptable for you?


    > And really, your patch quality stinks, I strongly suggest getting a lot
    > more experience with C first before doing more kernel work please.

    Can you accept any specific update steps while other software changes
    will evolve after a bit of discussion as usual?

    Regards,
    Markus

    \
     
     \ /
      Last update: 2016-09-17 09:56    [W:4.605 / U:0.856 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site