Messages in this thread | | | Subject | Re: [PATCH v1] power: reset: reboot mode: fix build error of missing ioremap/iounmap on UM | From | Krzysztof Kozlowski <> | Date | Fri, 12 Aug 2016 14:48:40 +0200 |
| |
On 08/12/2016 12:01 PM, Andy Yan wrote: > commit 4fcd504edbf7 ("power: reset: add reboot mode driver") uses api from > syscon, and syscon uses ioremap/iounmap which depends on HAS_IOMEM, so > let's depend on MFD_SYSCON instead of selecting it directly to avoid the > um-allyesconfig like build error on archs that without iomem: > > drivers/mfd/syscon.c: In function 'of_syscon_register': > drivers/mfd/syscon.c:67:9: error: implicit declaration of function 'ioremap' [-Werror=implicit-function-declaration] > base = ioremap(res.start, resource_size(&res)); > ^ > drivers/mfd/syscon.c:67:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion] > base = ioremap(res.start, resource_size(&res)); > ^ > drivers/mfd/syscon.c:109:2: error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration] > iounmap(base); > ^ > > Reported-by: Kbuild test robot <fengguang.wu@intel.com> > Fixes: 4fcd504edbf7("power: reset: add reboot mode driver") > Signed-off-by: Andy Yan <andy.yan@rock-chips.com> > > --- > > Changes in v1: > - let this driver depend on MFD_SYSCON > - add Reported-by tag, which suggested by Krzysztof Kozlowski > - add Fixes tag, which suggested by Matthias Brugger > > drivers/power/reset/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards, Krzysztof
| |