Messages in this thread Patch in this message | | | Date | Fri, 12 Aug 2016 08:36:54 +0530 | From | Amitoj Kaur Chawla <> | Subject | [PATCH] MIPS: ath79: Modify error handling |
| |
clk_register_fixed_factor returns an ERR_PTR in case of an error and should have an IS_ERR check instead of a null check.
The Coccinelle semantic patch used to find this issue is as follows: @@ expression e; statement S; @@
*e = clk_register_fixed_factor(...); if (!e) S
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> --- arch/mips/ath79/clock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/ath79/clock.c b/arch/mips/ath79/clock.c index 2e73784..cc3a1e3 100644 --- a/arch/mips/ath79/clock.c +++ b/arch/mips/ath79/clock.c @@ -96,7 +96,7 @@ static struct clk * __init ath79_reg_ffclk(const char *name, struct clk *clk; clk = clk_register_fixed_factor(NULL, name, parent_name, 0, mult, div); - if (!clk) + if (IS_ERR(clk)) panic("failed to allocate %s clock structure", name); return clk; -- 1.9.1
| |