lkml.org 
[lkml]   [2016]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 04/18] autofs - fix autofs4_fill_super() error exit handling
    From
    Date
    Somewhere along the line the error handling gotos have become incorrect.

    Signed-off-by: Ian Kent <raven@themaw.net>
    Cc: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
    ---
    fs/autofs4/inode.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/fs/autofs4/inode.c b/fs/autofs4/inode.c
    index 8357544..64d721f 100644
    --- a/fs/autofs4/inode.c
    +++ b/fs/autofs4/inode.c
    @@ -313,7 +313,7 @@ int autofs4_fill_super(struct super_block *s, void *data, int silent)

    if (!pipe) {
    pr_err("could not open pipe file descriptor\n");
    - goto fail_dput;
    + goto fail_put_pid;
    }
    ret = autofs_prepare_pipe(pipe);
    if (ret < 0)
    @@ -334,14 +334,14 @@ int autofs4_fill_super(struct super_block *s, void *data, int silent)
    fail_fput:
    pr_err("pipe file descriptor does not contain proper ops\n");
    fput(pipe);
    - /* fall through */
    +fail_put_pid:
    + put_pid(sbi->oz_pgrp);
    fail_dput:
    dput(root);
    goto fail_free;
    fail_ino:
    kfree(ino);
    fail_free:
    - put_pid(sbi->oz_pgrp);
    kfree(sbi);
    s->s_fs_info = NULL;
    return ret;
    \
     
     \ /
      Last update: 2016-09-17 09:56    [W:8.838 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site