lkml.org 
[lkml]   [2016]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] perf intel-pt: Fix ip compression
From
Date
On 20/07/16 12:00, Adrian Hunter wrote:
> June 2015 Intel SDM introduced IP Compression types 4 and 6. Refer section
> 36.4.2.2 Target IP (TIP) Packet - IP Compression.
>
> Existing Intel PT packet decoder did not support type 4, and got type 6
> wrong. Because type 3 and type 4 have the same number of bytes, the packet
> 'count' has been changed from being the number of ip bytes to being the
> type code. That allows the Intel PT decoder to correctly decide whether to
> sign-extend or use the last ip. However that also meant the code had to be
> adjusted in a number of places.
>
> Currently hardware is not using the new compression types, so this fix has
> no effect on existing hardware.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> .../perf/util/intel-pt-decoder/intel-pt-decoder.c | 44 +++++++++++-----------
> .../util/intel-pt-decoder/intel-pt-pkt-decoder.c | 24 ++++++++----
> 2 files changed, 40 insertions(+), 28 deletions(-)

Hi

This is outstanding but still applies.

Regards
Adrian


\
 
 \ /
  Last update: 2016-08-11 00:01    [W:0.054 / U:0.896 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site