lkml.org 
[lkml]   [2016]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V3 2/2] perf/x86/intel/uncore: add enable_box for client msr uncore

* kan.liang@intel.com <kan.liang@intel.com> wrote:

> From: Kan Liang <kan.liang@intel.com>
>
> PERF_GLOBAL_CTL could be cleared after Package C7. This patch tries to
> workaround this issue by re-enable PERF_GLOBAL_CTL in enable_box.
> The workaround does not cover all cases. It helps for new events after
> returning from C7.
> There is no drawback in letting the thing enabled, so it does not need
> disable_box here.

This changelog is very poor for similar reasons as:

Re: [PATCH] perf/x86/intel/uncore: correct uncore num_counters

Please fix the changelog to conform to the standard changelog style:

- first describe the symptoms of the bug - how does a user notice?

- then describe how the code behaves today and how that is causing the bug

- and then only describe how it's fixed.

The first item is the most important one - while developers
(naturally) tend to concentrate on the least important point, the last
one.

Thanks,

Ingo

\
 
 \ /
  Last update: 2016-08-10 22:41    [W:0.065 / U:2.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site