lkml.org 
[lkml]   [2016]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] omapfb/dss: wait_for_completion_interruptible_timeout expects long
From
Date
On 25/07/16 20:12, Nicholas Mc Guire wrote:
> wait_for_completion_timeout_interruptible returns long not unsigned long.
> an appropriately typed variable is introduced and assignments fixed up.
>
> Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb")
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> ---
>
> API non-compliance was located by coccinelle
>
> This is mostly cosmetic since the returned value is only compared
> at present, however if remaining time (completion occurred) where ever
> used, then a signal received would be interpreted as a large remaining
> jiffies left, which would be wrong.
>
> Compile tested with: omap2plus_defconfig (implies CONFIG_FB_OMAP2_DSS)
>
> Patch is against 4.7.0-rc7 (localversion-next -next-20160724)
>
> drivers/video/fbdev/omap2/omapfb/dss/dispc-compat.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)

Thanks, queued for v4.9. I dropped the "Fixes: " line, as that commit
only does a copy of the files, so the commit didn't really introduce the
bug.

Tomi

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-08-10 22:41    [W:0.064 / U:2.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site