lkml.org 
[lkml]   [2016]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] x86/hpet: fix typo from rtc cleanup
From
Date
Hi

On 08/09/2016 10:54 PM, Arnd Bergmann wrote:
> Ville Syrjälä reports "The first time I run hwclock after rebooting
> I get this:
>
> open("/dev/rtc", O_RDONLY) = 3
> ioctl(3, PHN_SET_REGS or RTC_UIE_ON, 0) = 0
> select(4, [3], NULL, NULL, {10, 0}) = 0 (Timeout)
> ioctl(3, PHN_NOT_OH or RTC_UIE_OFF, 0) = 0
> close(3) = 0
>
> On all subsequent runs I get this:
> open("/dev/rtc", O_RDONLY) = 3
> ioctl(3, PHN_SET_REGS or RTC_UIE_ON, 0) = -1 EINVAL (Invalid argument)
> ioctl(3, RTC_RD_TIME, 0x7ffd76b3ae70) = -1 EINVAL (Invalid argument)
> close(3) = 0"
>
> This was caused by a stupid typo in a patch that should have been
> a simple rename to move around contents of a header file, but
> accidentally wrote zeroes into the rtc rather than reading from
> it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Tested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Fixes: 463a86304cae ("char/genrtc: x86: remove remnants of asm/rtc.h")
> ---
> arch/x86/kernel/hpet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
I started seeing system reboots and lockups during kernel boot on a
prototype HW this week using v4.8-rc1 and bisected to this same commit.

This patch fixes the issue.

Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>

\
 
 \ /
  Last update: 2016-08-10 22:21    [W:0.085 / U:28.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site