lkml.org 
[lkml]   [2016]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] fbdev: Remove deprecated create_singlethread_workqueue
From
Date


On 02/07/16 11:39, Bhaktipriya Shridhar wrote:
> The workqueue "esd_wq" has only a single workitem(&md->esd_work)
> and hence doesn't require ordering. Also, it is not being used on a
> memory reclaim path. Hence, the singlethreaded workqueue has been
> replaced with the use of system_wq.
>
> System workqueues have been able to handle high level of concurrency
> for a long time now and hence it's not required to have a singlethreaded
> workqueue just to gain concurrency. Unlike a dedicated per-cpu workqueue
> created with create_singlethread_workqueue(), system_wq allows multiple
> work items to overlap executions even on the same CPU; however, a
> per-cpu workqueue doesn't have any CPU locality or global ordering
> guarantee unless the target CPU is explicitly specified and thus the
> increase of local concurrency shouldn't make any difference.
>
> mipid_esd_stop_check () calls cancel_delayed_work() in mipid_cleanup()
> to ensure that there are no pending tasks while disconnecting the driver.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> ---
> drivers/video/fbdev/omap/lcd_mipid.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)

Thanks, queued for v4.9.

Tomi

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-08-10 21:41    [W:0.055 / U:1.576 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site