lkml.org 
[lkml]   [2016]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] IB/hfi1: Add missing error code assignment before test
Date
On Wed, 2016-08-10 at 07:34 +0200, Christophe JAILLET wrote:
> It is likely that checking the result of 'setup_ctxt' is expected
> here.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/infiniband/hw/hfi1/file_ops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/hfi1/file_ops.c
> b/drivers/infiniband/hw/hfi1/file_ops.c
> index 1ecbec192358..ed76be39b20b 100644
> --- a/drivers/infiniband/hw/hfi1/file_ops.c
> +++ b/drivers/infiniband/hw/hfi1/file_ops.c
> @@ -222,7 +222,7 @@ static long hfi1_file_ioctl(struct file *fp,
> unsigned int cmd,
>   ret = assign_ctxt(fp, &uinfo);
>   if (ret < 0)
>   return ret;
> - setup_ctxt(fp);
> + ret = setup_ctxt(fp);
>   if (ret)
>   return ret;
>   ret = user_init(fp);

Thanks for the patch.

Acked-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
\
 
 \ /
  Last update: 2016-08-10 21:21    [W:0.049 / U:7.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site