[lkml]   [2016]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] max17042_battery: fix model download bug.
On 08/09/2016 08:54 PM, Sebastian Reichel wrote:
> Hi,
> [adding some people to CC]
> On Wed, Aug 03, 2016 at 10:03:46AM -0400, Sven Van Asbroeck wrote:
>> The device's model download function returns the model data as
>> an array of u32s, which is later compared to the reference
>> model data. However, since the latter is an array of u16s,
>> the comparison does not happen correctly, and model verification
>> fails. This in turn breaks the POR initialization sequence.
> Patch looks ok, except for missing Fixes. I guess it should be
> "Fixes: 39e7213edc4f3". I will wait with queuing it for a few
> days giving Samsung people a chance to reply.

Looks correct.
Reviewed-by: Krzysztof Kozlowski <>

Cc: <>

And how about:
Reported-by: Dan Carpenter <>

Best regards,

 \ /
  Last update: 2016-08-10 21:21    [W:0.069 / U:5.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site