Messages in this thread | | | Subject | Re: [PATCH] max17042_battery: fix model download bug. | From | Krzysztof Kozlowski <> | Date | Wed, 10 Aug 2016 10:27:07 +0200 |
| |
On 08/09/2016 08:54 PM, Sebastian Reichel wrote: > Hi, > > [adding some people to CC] > > On Wed, Aug 03, 2016 at 10:03:46AM -0400, Sven Van Asbroeck wrote: >> The device's model download function returns the model data as >> an array of u32s, which is later compared to the reference >> model data. However, since the latter is an array of u16s, >> the comparison does not happen correctly, and model verification >> fails. This in turn breaks the POR initialization sequence. > > Patch looks ok, except for missing Fixes. I guess it should be > "Fixes: 39e7213edc4f3". I will wait with queuing it for a few > days giving Samsung people a chance to reply.
Looks correct. Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Also: Cc: <stable@vger.kernel.org>
And how about: Reported-by: Dan Carpenter <dan.carpenter@oracle.com> https://www.marc.info/?l=linux-pm&m=143954612610000&w=4
Best regards, Krzysztof
| |