Messages in this thread | | | Date | Mon, 1 Aug 2016 12:56:56 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues |
| |
On Mon, 1 Aug 2016 11:24:59 -0500 Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> > > - print_ftrace_graph_addr(addr, data, ops, task, graph); > > > + > > > + real_addr = ftrace_graph_ret_addr(task, graph, addr); > > > + if (addr != real_addr) > > > + ops->address(data, addr, 0); > > > + ops->address(data, real_addr, reliable); > > > > Note this changes behavior, as the original code had the ret_to_handler > > first. This makes it second. (I fixed this below). > > Hm, as far as I can tell this actually keeps the original behavior. The > "unreliable" ret_to_handler is still printed first, no? >
Yep, I guess it does. I mixed up the meaning of "real_addr" and "addr", and was thinking of the reverse.
-- Steve
| |