Messages in this thread | | | Date | Mon, 01 Aug 2016 15:17:03 +0100 | From | Luis de Bethencourt <> | Subject | Re: [PATCH 5/6] fs: befs: remove in vain variable assignment |
| |
On 31/07/16 21:34, Salah Triki wrote: > There is no need to init res, since it will be overwitten later by > befs_fblock2brun(). > > Signed-off-by: Salah Triki <salah.triki@gmail.com> > --- > fs/befs/linuxvfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c > index 6bc5b40..2b68c81 100644 > --- a/fs/befs/linuxvfs.c > +++ b/fs/befs/linuxvfs.c > @@ -120,7 +120,7 @@ befs_get_block(struct inode *inode, sector_t block, > struct super_block *sb = inode->i_sb; > befs_data_stream *ds = &BEFS_I(inode)->i_data.ds; > befs_block_run run = BAD_IADDR; > - int res = 0; > + int res; > ulong disk_off; > > befs_debug(sb, "---> befs_get_block() for inode %lu, block %ld", >
Looks good.
Thanks Salah, Luis
Acked-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Pushed to the befs-next branch: https://github.com/luisbg/linux-befs/tree/befs-next
| |