lkml.org 
[lkml]   [2016]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v12 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support
Date
Hi Vinod,

Thanks for the review...

> > +
> > + chan->is_dmacoherent = of_property_read_bool(node, "dma-
> coherent");
> > + zdev->chan = chan;
> > + tasklet_init(&chan->tasklet, zynqmp_dma_do_tasklet, (ulong)chan);
>
> where is this killed?

This is killed in the zynqmp_dma_chan_remove() API.

>
> > + spin_lock_init(&chan->lock);
> > + INIT_LIST_HEAD(&chan->active_list);
> > + INIT_LIST_HEAD(&chan->pending_list);
> > + INIT_LIST_HEAD(&chan->done_list);
> > + INIT_LIST_HEAD(&chan->free_list);
> > + zynqmp_dma_init(chan);
> > + chan->irq = platform_get_irq(pdev, 0);
> > + if (chan->irq < 0)
> > + return -ENXIO;
> > + err = devm_request_irq(&pdev->dev, chan->irq,
> zynqmp_dma_irq_handler, 0,
> > + "zynqmp-dma", chan);
>
> this needs to be freed/diabled in remove, dont see that

It is freed in the zynqmp_dma_chan_remove() API.

Regards,
Kedar.

\
 
 \ /
  Last update: 2016-07-09 11:21    [W:0.123 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site