Messages in this thread Patch in this message | | | From | Markus Mayer <> | Subject | [PATCH v3 3/7] ACPI / device_sysfs: make use of new strtolower() function | Date | Fri, 8 Jul 2016 15:43:10 -0700 |
| |
Call strtolower() rather than walking the string explicitly to convert it to lowercase.
Signed-off-by: Markus Mayer <mmayer@broadcom.com> ---
Rafael, I left off your ACK, since the implementation of my function changed somewhat (doesn't check the argument NULL, doesn't return anything). Please let me know if you are still okay with this.
drivers/acpi/device_sysfs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c index 7b2c48f..1db38c7 100644 --- a/drivers/acpi/device_sysfs.c +++ b/drivers/acpi/device_sysfs.c @@ -200,12 +200,10 @@ static int create_of_modalias(struct acpi_device *acpi_dev, char *modalias, const union acpi_object *of_compatible, *obj; int len, count; int i, nval; - char *c; acpi_get_name(acpi_dev->handle, ACPI_SINGLE_NAME, &buf); /* DT strings are all in lower case */ - for (c = buf.pointer; *c != '\0'; c++) - *c = tolower(*c); + strtolower(buf.pointer); len = snprintf(modalias, size, "of:N%sT", (char *)buf.pointer); ACPI_FREE(buf.pointer); -- 2.7.4
| |