Messages in this thread | | | Date | Fri, 8 Jul 2016 20:56:11 +0800 | From | Baoquan He <> | Subject | Re: [PATCH v2 2/2] x86/acpi: Remove the repeated lapic address override entry parsing |
| |
On 07/08/16 at 02:27pm, Ingo Molnar wrote: > > * Baoquan He <bhe@redhat.com> wrote: > > > ACPI MADT has a 32-bit field providing lapic address at which > > each processor can access its lapic information. MADT also contains > > an optional entry to provide a 64-bit address to override the 32-bit > > one. However the current code does the lapic address override entry > > parsing twice. One is in early_acpi_boot_init() because AMD NUMA need > > get boot_cpu_id earlier. The other is in acpi_boot_init() which parses > > all MADT entries. > > > > So in this patch remove the repeated code in the 2nd part. Meanwhile > > print lapic override entry information like other MADT entry. > > So this patch is not supposed to change behavior (modulo kernel messages), right? > If so it would make sense to spell that out explicitly in the changelog.
Yes, it won't. I will mention it in changelog and repost. Thanks for your reviewing.
Thanks Baoquan
| |