Messages in this thread | | | Date | Fri, 8 Jul 2016 11:21:35 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 1/6] x86/mce/AMD: Increase size of bank_map type |
| |
* Borislav Petkov <bp@alien8.de> wrote:
> From: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com> > > Change bank_map type from char to int since we now have more than eight > banks in a system. > > Signed-off-by: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com> > Cc: Aravind Gopalakrishnan <aravindksg.lkml@gmail.com> > Cc: Tony Luck <tony.luck@intel.com> > Cc: linux-edac <linux-edac@vger.kernel.org> > Link: http://lkml.kernel.org/r/1466462163-29008-1-git-send-email-Yazen.Ghannam@amd.com > Signed-off-by: Yazen Ghannam <Yazen.Ghannam@amd.com> > Signed-off-by: Borislav Petkov <bp@suse.de> > --- > arch/x86/kernel/cpu/mcheck/mce_amd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/cpu/mcheck/mce_amd.c b/arch/x86/kernel/cpu/mcheck/mce_amd.c > index 10b0661651e0..7b7f3be783d4 100644 > --- a/arch/x86/kernel/cpu/mcheck/mce_amd.c > +++ b/arch/x86/kernel/cpu/mcheck/mce_amd.c > @@ -93,7 +93,7 @@ const char * const amd_df_mcablock_names[] = { > EXPORT_SYMBOL_GPL(amd_df_mcablock_names); > > static DEFINE_PER_CPU(struct threshold_bank **, threshold_banks); > -static DEFINE_PER_CPU(unsigned char, bank_map); /* see which banks are on */ > +static DEFINE_PER_CPU(unsigned int, bank_map); /* see which banks are on */
Btw., is there any check somewhere which printed a helpful warning when we exceeded the 8 banks limit - and which would prints a helpful warning if we ever exceed the 32 banks limit?
Thanks,
Ingo
| |