lkml.org 
[lkml]   [2016]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 31/31] mm, vmstat: Remove zone and node double accounting by approximating retries
On Wed, Jul 06, 2016 at 11:12:52AM -0700, Dave Hansen wrote:
> On 07/01/2016 01:01 PM, Mel Gorman wrote:
> > +#ifdef CONFIG_HIGHMEM
> > +extern unsigned long highmem_file_pages;
> > +
> > +static inline void acct_highmem_file_pages(int zid, enum lru_list lru,
> > + int nr_pages)
> > +{
> > + if (is_highmem_idx(zid) && is_file_lru(lru))
> > + highmem_file_pages += nr_pages;
> > +}
> > +#else
>
> Shouldn't highmem_file_pages technically be an atomic_t (or atomic64_t)?
> We could have highmem on two nodes which take two different LRU locks.

It would require a NUMA machine with highmem or very weird
configurations but sure, atomic is safer.

--
Mel Gorman
SUSE Labs

\
 
 \ /
  Last update: 2016-07-07 14:01    [W:0.153 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site