lkml.org 
[lkml]   [2016]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Xen-devel] [PATCH] xen-blkback: prefer xenbus_write() over xenbus_printf() where possible
From
Date
On 07/07/16 09:06, Jan Beulich wrote:
> ... as being the simpler variant.
[...]
> --- 4.7-rc6-prefer-xenbus_write.orig/drivers/block/xen-blkback/xenbus.c
> +++ 4.7-rc6-prefer-xenbus_write/drivers/block/xen-blkback/xenbus.c
> @@ -617,9 +617,9 @@ static int xen_blkbk_probe(struct xenbus
> goto fail;
> }
>
> - err = xenbus_printf(XBT_NIL, dev->nodename,
> - "feature-max-indirect-segments", "%u",
> - MAX_INDIRECT_SEGMENTS);
> + err = xenbus_write(XBT_NIL, dev->nodename,
> + "feature-max-indirect-segments",
> + __stringify(MAX_INDIRECT_SEGMENTS));

Yuk :(

Now someone has to check both __stringify() and MAX_INDIRECT_SEGMENTS to
work out what this actually looks like.

David

\
 
 \ /
  Last update: 2016-07-07 12:41    [W:0.057 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site