lkml.org 
[lkml]   [2016]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.6 17/31] USB: uas: Fix slave queue_depth not being set
    Date
    4.6-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Hans de Goede <hdegoede@redhat.com>

    commit 593224ea77b1ca842f45cf76f4deeef44dfbacd1 upstream.

    Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level")
    removed the scsi_change_queue_depth() call from uas_slave_configure()
    assuming that the slave would inherit the host's queue_depth, which
    that commit sets to the same value.

    This is incorrect, without the scsi_change_queue_depth() call the slave's
    queue_depth defaults to 1, introducing a performance regression.

    This commit restores the call, fixing the performance regression.

    Fixes: 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level")
    Reported-by: Tom Yan <tom.ty89@gmail.com>
    Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/storage/uas.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/usb/storage/uas.c
    +++ b/drivers/usb/storage/uas.c
    @@ -835,6 +835,7 @@ static int uas_slave_configure(struct sc
    if (devinfo->flags & US_FL_BROKEN_FUA)
    sdev->broken_fua = 1;

    + scsi_change_queue_depth(sdev, devinfo->qdepth - 2);
    return 0;
    }


    \
     
     \ /
      Last update: 2016-07-07 04:21    [W:3.224 / U:0.816 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site