lkml.org 
[lkml]   [2016]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 01/21] backports: move legacy and SmPL patch application into helper
On Mon, Jul 04, 2016 at 11:33:03AM +0200, Johannes Berg wrote:
> On Tue, 2014-11-11 at 00:14 -0800, Luis R. Rodriguez wrote:
> > From: "Luis R. Rodriguez" <mcgrof@suse.com>
> >
> > This allows us to extend how backports uses patches for
> > different types of applications. This will later be used
> > for kernel integration support, for example.
> >
> > This should have no functional change.
>
> Obviously this patch was applied a long time ago,

Geesh yes over 2 year ago.

> but you lied - it has a functional change:
>
> > +        if process.returncode != 0:
> > +            if not args.verbose:
> > +                logwrite("Failed to apply changes from %s" %
> > print_name)
> > +                for line in output:
> > +                    logwrite('> %s' % line)
> > +            raise Exception('Patch failed')
>
> vs.
>
> > -        if process.returncode != 0:
> > -            if not args.verbose:
> > -                logwrite("Failed to apply changes from %s" %
> > print_name)
> > -                for line in output:
> > -                    logwrite('> %s' % line)
> > -            return 2
>
> This had a major impact on the devel/git-tracker.py tool.

Sorry about that, is there an easy fix for it? Is there a test
we can do to avoid further regressions against the tracker ?

Luis

\
 
 \ /
  Last update: 2016-07-07 03:01    [W:0.050 / U:1.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site