lkml.org 
[lkml]   [2016]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH -next] orangefs: use vzalloc() instead of vmalloc()/memset(0)
Wei...

I have applied your patch and tested it, it seems good.

The gossip statement still references vmalloc, I used
"git commit --amend" to fix that for my test. I'll do the
same when I push to kernel.org too, if you're OK with that,
unless you want to fix it yourself and resend the patch...

Thanks!

-Mike

On Wed, Jul 6, 2016 at 9:23 AM, <weiyj_lk@163.com> wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Use vzalloc() instead of vmalloc() and memset(0).
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> fs/orangefs/devorangefs-req.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/orangefs/devorangefs-req.c b/fs/orangefs/devorangefs-req.c
> index a287a66..e839073 100644
> --- a/fs/orangefs/devorangefs-req.c
> +++ b/fs/orangefs/devorangefs-req.c
> @@ -442,14 +442,12 @@ static ssize_t orangefs_devreq_write_iter(struct kiocb *iocb,
> if (op->downcall.type != ORANGEFS_VFS_OP_READDIR)
> goto wakeup;
>
> - op->downcall.trailer_buf =
> - vmalloc(op->downcall.trailer_size);
> + op->downcall.trailer_buf = vzalloc(op->downcall.trailer_size);
> if (op->downcall.trailer_buf == NULL) {
> gossip_err("%s: failed trailer vmalloc.\n",
> __func__);
> goto Enomem;
> }
> - memset(op->downcall.trailer_buf, 0, op->downcall.trailer_size);
> n = copy_from_iter(op->downcall.trailer_buf,
> op->downcall.trailer_size,
> iter);
>
>
>
>

\
 
 \ /
  Last update: 2016-07-06 19:41    [W:0.049 / U:0.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site