lkml.org 
[lkml]   [2016]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel
On 4 July 2016 at 07:27, Vinay Simha <simhavcs@gmail.com> wrote:
> On Mon, Jul 4, 2016 at 4:22 AM, Emil Velikov <emil.l.velikov@gmail.com> wrote:
>> On 28 June 2016 at 16:59, Vinay Simha <simhavcs@gmail.com> wrote:
>>> hi,
>>>
>>> Any further comments or reviews?
>>>
>> You still haven't covered my earlier suggestions, as such I cannot
>> give you a r-b :-( They are not blockers by any means, but it'll be
>> up-to the maintainer to ack/pick this up.
> i do have covered the suggestions from you.
> As i had mentioned earlier we cannot drop few returns and keep it
> void(drm_panel_funcs - unprepare), since drm framework requires
> return. if do you have any alternate solution please suggest, will
> incorporate.
Please re-read what I said. I don't recall suggesting changes to the
vfunc signature but the helper that you're calling. Why ? Because it's
uncommon/unwise to prematurely exit during the teardown/destructor
stage.

Although as said previously, its nothing serious, hence why people
rarely bother.
-Emil

\
 
 \ /
  Last update: 2016-07-06 19:41    [W:0.048 / U:14.936 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site