lkml.org 
[lkml]   [2016]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] pinctrl: imx21: include linux/module.h
Date
On Wednesday, July 6, 2016 9:21:39 AM CEST Paul Gortmaker wrote:
> > --- a/drivers/pinctrl/freescale/pinctrl-imx21.c
> > +++ b/drivers/pinctrl/freescale/pinctrl-imx21.c
> > @@ -325,7 +325,6 @@ static const struct of_device_id imx21_pinctrl_of_match[] =
> > { .compatible = "fsl,imx21-iomuxc", },
> > { }
> > };
> > -MODULE_DEVICE_TABLE(of, imx21_pinctrl_of_match);
> >
> > static struct platform_driver imx21_pinctrl_driver = {
> > .driver = {
> >
> >
> > If you agree I can send a formal patch.
>
> Yes, deleting the MODULE_DEVICE_TABLE is the right fix. I'm curious why
> that never showed up in all the build coverage I did...

I needed several hundred randconfig builds before hitting it, I think
it's just rare because the driver is not enabled most of the time, and
it's possible that the header sometimes gets included implicitly.

Arnd

\
 
 \ /
  Last update: 2016-07-06 16:21    [W:0.061 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site