lkml.org 
[lkml]   [2016]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH -next] memory: atmel-ebi: use PTR_ERR_OR_ZERO() to simplify the code
Hi,

On 06/07/2016 at 12:08:05 +0000, weiyj_lk@163.com wrote :
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR.
>

I'm guessing you found that using coccinnelle or any other static
analysis tool. Can you mention that in the commit message?

> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/memory/atmel-ebi.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/memory/atmel-ebi.c b/drivers/memory/atmel-ebi.c
> index f87ad6f..b5ed3bd 100644
> --- a/drivers/memory/atmel-ebi.c
> +++ b/drivers/memory/atmel-ebi.c
> @@ -410,10 +410,7 @@ static int at91sam9_ebi_init(struct at91_ebi *ebi)
>
> field.reg = AT91SAM9_SMC_MODE(AT91SAM9_SMC_GENERIC);
> fields->mode = devm_regmap_field_alloc(ebi->dev, ebi->smc, field);
> - if (IS_ERR(fields->mode))
> - return PTR_ERR(fields->mode);
> -
> - return 0;
> + return PTR_ERR_OR_ZERO(fields->mode);
> }
>
> static int sama5d3_ebi_init(struct at91_ebi *ebi)
> @@ -441,10 +438,7 @@ static int sama5d3_ebi_init(struct at91_ebi *ebi)
>
> field.reg = SAMA5_SMC_MODE(SAMA5_SMC_GENERIC);
> fields->mode = devm_regmap_field_alloc(ebi->dev, ebi->smc, field);
> - if (IS_ERR(fields->mode))
> - return PTR_ERR(fields->mode);
> -
> - return 0;
> + return PTR_ERR_OR_ZERO(fields->mode);
> }
>
> static int at91_ebi_dev_setup(struct at91_ebi *ebi, struct device_node *np,
>
>

--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

\
 
 \ /
  Last update: 2016-07-06 15:01    [W:0.037 / U:32.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site