lkml.org 
[lkml]   [2016]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/2] qe/ic: move qe_ic_init from platforms to irqchip
Date
On 07/05/2016 11:19 AM, Jason Cooper <jason@lakedaemon.net> wrote:

> -----Original Message-----
> From: Jason Cooper [mailto:jason@lakedaemon.net]
> Sent: Tuesday, July 05, 2016 10:22 PM
> To: Qiang Zhao <qiang.zhao@nxp.com>
> Cc: oss@buserror.net; tglx@linutronix.de; marc.zyngier@arm.com; linuxppc-
> dev@lists.ozlabs.org; linux-kernel@vger.kernel.org; Xiaobo Xie
> <xiaobo.xie@nxp.com>
> Subject: Re: [PATCH 1/2] qe/ic: move qe_ic_init from platforms to irqchip
>
> On Tue, Jul 05, 2016 at 07:27:21AM +0000, Qiang Zhao wrote:
> > On 07/05/2016 11:19 AM, Jason Cooper <jason@lakedaemon.net> wrote:
> > > -----Original Message-----
> > > From: Jason Cooper [mailto:jason@lakedaemon.net]
> > > Sent: Tuesday, July 05, 2016 11:19 AM
> > > To: Qiang Zhao <qiang.zhao@nxp.com>
> > > Cc: oss@buserror.net; tglx@linutronix.de; marc.zyngier@arm.com;
> > > linuxppc- dev@lists.ozlabs.org; linux-kernel@vger.kernel.org; Xiaobo
> > > Xie <xiaobo.xie@nxp.com>
> > > Subject: Re: [PATCH 1/2] qe/ic: move qe_ic_init from platforms to
> > > > diff --git a/arch/powerpc/platforms/83xx/misc.c
> > > > b/arch/powerpc/platforms/83xx/misc.c
> > > > index 7e923ca..9431fc7 100644
> > > > --- a/arch/powerpc/platforms/83xx/misc.c
> > > > +++ b/arch/powerpc/platforms/83xx/misc.c
> > > > @@ -93,24 +93,9 @@ void __init mpc83xx_ipic_init_IRQ(void) }
> > > >
> > > > #ifdef CONFIG_QUICC_ENGINE
> > > > -void __init mpc83xx_qe_init_IRQ(void) -{
> > > > - struct device_node *np;
> > > > -
> > > > - np = of_find_compatible_node(NULL, NULL, "fsl,qe-ic");
> > > > - if (!np) {
> > > > - np = of_find_node_by_type(NULL, "qeic");
> > > > - if (!np)
> > > > - return;
> > > > - }
> > >
> > > This block isn't preserved in the irqchip driver. Why not?
> >
> > I grep qeic in arch/powerpc/boot/dts/*, doesn't find which board use qeic as
> type.
>
> Unfortunately, checking powerpc/boot/dts/* isn't sufficient for confirming we
> aren't going to break backwards compatibility with boards *in the field*.
>
> Please take a look at:
>
> d4fb5ebd83c70 powerpc/83xx: consolidate init_IRQ functions
> 8159df72d43e2 83xx: add support for the kmeter1 board.
>
> Perhaps one or two of the authors is still around and can say why that check is
> there and if it's ok to remove it.
>
> Or, we could just play it safe and keep the check.
>

Ok, I will add this check in next version.

Thanks
-Zhao Qiang

\
 
 \ /
  Last update: 2016-07-06 04:21    [W:0.116 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site