Messages in this thread | | | Subject | Re: [PATCH 2/2] net: ethernet: bcmgenet: use phy_ethtool_{get|set}_link_ksettings | From | Florian Fainelli <> | Date | Mon, 4 Jul 2016 21:30:04 -0700 |
| |
Le 04/07/2016 16:03, David Miller a écrit : > From: Philippe Reynes <tremyfr@gmail.com> > Date: Sun, 3 Jul 2016 17:33:57 +0200 > >> There are two generics functions phy_ethtool_{get|set}_link_ksettings, >> so we can use them instead of defining the same code in the driver. >> >> Signed-off-by: Philippe Reynes <tremyfr@gmail.com> > > Applied. >
The transformation is not equivalent, we lost the checks on netif_running() in the process, and those are here for a reason, if the interface is down and therefore clock gated, MDIO accesses to the PHY will simply fail outright and cause bus errors.
Philippe, have you tested this? -- Florian
| |