lkml.org 
[lkml]   [2016]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next 01/24] rxrpc: Fix processing of authenticated/encrypted jumbo packets
From
Date
Hello.

On 07/05/2016 04:12 PM, David Howells wrote:

> When a jumbo packet is being split up and processed, the crypto checksum
> for each split-out packet is in the jumbo header and needs placing in the
> reconstructed packet header.
>
> When commit 0d12f8a4027d021c9cc942f09f38d28288020c5d moved to keeping the

scripts/checkpatch.pl now enforces the common commit citing style as for
the Fixes: tag and the patch description, you need to specify the summary too.

> stored copy of the packet header in host byte order, this reconstruction
> was missed.
>
> Found with sparse with CF=-D__CHECK_ENDIAN__:
>
> ../net/rxrpc/input.c:479:33: warning: incorrect type in assignment (different base types)
> ../net/rxrpc/input.c:479:33: expected unsigned short [unsigned] [usertype] _rsvd
> ../net/rxrpc/input.c:479:33: got restricted __be16 [addressable] [usertype] _rsvd
>
> Signed-off-by: David Howells <dhowells@redhat.com>
[...]

MBR, Sergei

\
 
 \ /
  Last update: 2016-07-05 20:41    [W:0.156 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site