lkml.org 
[lkml]   [2016]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 1/4] dma-buf/fence-array: add fence_is_array()
From
Date
Am 05.07.2016 um 01:57 schrieb Gustavo Padovan:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>
> Add helper to check if fence is array.
>
> v2: Comments from Chris Wilson
> - remove ternary if from ops comparison
> - add EXPORT_SYMBOL(fence_array_ops)
>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Christian König <christian.koenig@amd.com>
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

For this patch Reviewed-by: Christian König <christian.koenig@amd.com>.

I'm not deep enough into the sync file code to fully judge, but the
remaining patches look good to me as well.

So for patch #2-#4 Acked-by: Christian König <christian.koenig@amd.com>.

Regards,
Christian.

> ---
> drivers/dma-buf/fence-array.c | 1 +
> include/linux/fence-array.h | 10 ++++++++++
> 2 files changed, 11 insertions(+)
>
> diff --git a/drivers/dma-buf/fence-array.c b/drivers/dma-buf/fence-array.c
> index a8731c8..ee50022 100644
> --- a/drivers/dma-buf/fence-array.c
> +++ b/drivers/dma-buf/fence-array.c
> @@ -99,6 +99,7 @@ const struct fence_ops fence_array_ops = {
> .wait = fence_default_wait,
> .release = fence_array_release,
> };
> +EXPORT_SYMBOL(fence_array_ops);
>
> /**
> * fence_array_create - Create a custom fence array
> diff --git a/include/linux/fence-array.h b/include/linux/fence-array.h
> index 86baaa4..a44794e 100644
> --- a/include/linux/fence-array.h
> +++ b/include/linux/fence-array.h
> @@ -52,6 +52,16 @@ struct fence_array {
> extern const struct fence_ops fence_array_ops;
>
> /**
> + * fence_is_array - check if a fence is from the array subsclass
> + *
> + * Return true if it is a fence_array and false otherwise.
> + */
> +static inline bool fence_is_array(struct fence *fence)
> +{
> + return fence->ops == &fence_array_ops;
> +}
> +
> +/**
> * to_fence_array - cast a fence to a fence_array
> * @fence: fence to cast to a fence_array
> *

\
 
 \ /
  Last update: 2016-07-05 16:41    [W:0.053 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site