lkml.org 
[lkml]   [2016]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/3] reset: socfpga: use readl/writel_relaxed
    Date
    This just removes the rmb()/wmb() pair between register read and
    write. Since no relevant reads follow the rmb and no relevant writes
    precede the wmb, they should be safe to remove.

    Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
    ---
    drivers/reset/reset-socfpga.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/reset/reset-socfpga.c b/drivers/reset/reset-socfpga.c
    index 78ebf84..4a65128 100644
    --- a/drivers/reset/reset-socfpga.c
    +++ b/drivers/reset/reset-socfpga.c
    @@ -44,8 +44,8 @@ static int socfpga_reset_assert(struct reset_controller_dev *rcdev,

    spin_lock_irqsave(&data->lock, flags);

    - reg = readl(data->membase + (bank * NR_BANKS));
    - writel(reg | BIT(offset), data->membase + (bank * NR_BANKS));
    + reg = readl_relaxed(data->membase + (bank * NR_BANKS));
    + writel_relaxed(reg | BIT(offset), data->membase + (bank * NR_BANKS));
    spin_unlock_irqrestore(&data->lock, flags);

    return 0;
    @@ -65,8 +65,8 @@ static int socfpga_reset_deassert(struct reset_controller_dev *rcdev,

    spin_lock_irqsave(&data->lock, flags);

    - reg = readl(data->membase + (bank * NR_BANKS));
    - writel(reg & ~BIT(offset), data->membase + (bank * NR_BANKS));
    + reg = readl_relaxed(data->membase + (bank * NR_BANKS));
    + writel_relaxed(reg & ~BIT(offset), data->membase + (bank * NR_BANKS));

    spin_unlock_irqrestore(&data->lock, flags);

    --
    2.8.1
    \
     
     \ /
      Last update: 2016-07-05 13:01    [W:2.752 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site