Messages in this thread |  | | Subject | Re: [PATCH v3 1/2] iio: adc: max1363: Add device tree binding documentation | From | Florian Vaussard <> | Date | Mon, 4 Jul 2016 08:56:05 +0200 |
| |
Hi Jonathan,
On 07/03/2016 12:41 PM, Jonathan Cameron wrote: > On 30/06/16 08:43, Florian Vaussard wrote: >> Add the device tree documentation for all the supported parts. Mandatory >> binding is the compatible string and the slave I2C address. >> >> Optional properties can be used to specify the Vcc / Vref regulators, as >> well as the IRQ line if available. >> >> Acked-by: Rob Herring <robh@kernel.org> >> Signed-off-by: Florian Vaussard <florian.vaussard@heig-vd.ch> > Really small point, but typically author sign off goes first then acks etc > that are gained at any intermediate states, then the sign off of whoever takes > the patch and applies it (here, that's me). So it kind of communicates some > idea of when in the process various tags were obtained. It's not a rule > set in stone though so I'll be lazy and leave this as it is. >
Agree, I will try to stick to this in the future. Looking at some previous patches, I see that I used both styles without noticing.
> Anyhow, great and applied to the togreg branch of iio.git initially pushed > out as testing for the autobuilders to poke it (or not in the case of this > docume >
Great. Do you plan to send them for the next merge window, or will you wait for the 4.9 cycle?
Best, Florian
|  |