[lkml]   [2016]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH 00/10] clk: fix/remove module usage in non-modular code
This series covers the audit of non-modular module code use in the
drivers/clk/ directory.

Quasi generic boiler plate description follows; included for folks who
haven't yet seen what we are aiming to achieve with this operation.

We are trying to not use module support for code that can never be built
as a module because:

(1) it is easy to accidentally write unused module_exit and remove code
(2) it can be misleading when reading the source, thinking it can be
modular when the Makefile and/or Kconfig prohibit it
(3) it requires the include of the module.h header file which in turn
includes nearly everything else, thus adding to CPP overhead.
(4) it gets copied/replicated into other code and spreads like weeds.

With respect to #1 in this instance, we see for these 10 commits:
15 files changed, 37 insertions(+), 227 deletions(-)
...which is a respectable (IMHO) net amount of removal of unused code.

Changes seen here cover the following categories:

-just replacement of modular macros with their non-modular
equivalents that CPP would have inserted anyway, such as:
module_init --> device_initcall
module_platform_driver --> builtin_platform_driver

-the removal of including module.h ; replaced with init.h
as required based on whether the file used it.

-the removal of any/all unused/orphaned __exit functions that
would never be called.

-the removal of instances of MODULE_DEVICE_TABLE and MODULE_ALIAS
that become no-ops in the non-modular case.

-the removal of any ".remove" functions that were hooked into
the driver struct. This ".remove" function would of
course not be called from the __exit function since that was
never run. However in theory, someone could have triggered it
via sysfs unbind, even though there isn't a sensible use case
for doing so. So to cover that possibility, we've also disabled
sysfs unbind in the driver.

-the removal of MODULE_DESCRIIPTION/AUTHOR/LICENSE tags that are
also no-ops for non-modular ; we ensure the information in those
tags is present in the top of file comments in each case.

There are no initcall level changes here; everything stays at the level
of initcall it was previously - either by not using modular versions to
begin with, or by using the builtin level equivalents.

As usual, we can consider making some of these tristate if an author
has strong feelings about extending support into the modular realm,
but I won't be able to run-time test any of that.

I batched the sunxi changes together since they had similar author
and maintainer fields and it helps avoid polluting history with too
many mundane commits, but I can split that up if so desired.

Build testing done on linux-next on arm/arm64 and x86/x86_64.


Cc: Aleksandr Frid <>
Cc: Alexandre Courbot <>
Cc: Boris BREZILLON <>
Cc: Carlo Caione <>
Cc: Chen-Yu Tsai <>
Cc: "Emilio López" <>
Cc: Kevin Hilman <>
Cc: Krzysztof Kozlowski <>
Cc: Kukjin Kim <>
Cc: Maxime Ripard <>
Cc: Michael Turquette <>
Cc: Neil Armstrong <>
Cc: Padmavathi Venna <>
Cc: Paul Walmsley <>
Cc: Peter De Schrijver <>
Cc: Peter Ujfalusi <>
Cc: Prashant Gaikwad <>
Cc: Stephen Boyd <>
Cc: Stephen Warren <>
Cc: Sylwester Nawrocki <>
Cc: Tero Kristo <>
Cc: Thierry Reding <>
Cc: Thomas Petazzoni <>
Cc: Tomasz Figa <>


Paul Gortmaker (10):
clk: meson8b: make it explicitly non-modular
clk: meson: make gxbb explicitly non-modular
clk: mvebu: make cp110-system-controller explicitly non-modular
clk: mvebu: make ap806-system-controller explicitly non-modular
clk: oxnas: make it explicitly non-modular
clk: samsung make clk-exynos-audss explicitly non-modular
clk: samsung: make clk-s5pv210-audss explicitly non-modular
clk: sunxi: make clk-* explicitly non-modular
clk: tegra: make clk-tegra124-dfll-fcpu explicitly non-modular
clk: ti: make clk-dra7-atl explicitly non-modular

drivers/clk/clk-oxnas.c | 15 +++----------
drivers/clk/meson/gxbb.c | 18 ++++-----------
drivers/clk/meson/meson8b-clkc.c | 19 ++++------------
drivers/clk/mvebu/ap806-system-controller.c | 23 +++----------------
drivers/clk/mvebu/cp110-system-controller.c | 34 +++--------------------------
drivers/clk/samsung/clk-exynos-audss.c | 13 +----------
drivers/clk/samsung/clk-s5pv210-audss.c | 29 ++----------------------
drivers/clk/sunxi/clk-factors.c | 1 -
drivers/clk/sunxi/clk-sun6i-apb0-gates.c | 9 ++------
drivers/clk/sunxi/clk-sun6i-apb0.c | 9 ++------
drivers/clk/sunxi/clk-sun6i-ar100.c | 21 +++---------------
drivers/clk/sunxi/clk-sun8i-apb0.c | 9 ++------
drivers/clk/sunxi/clk-sun9i-mmc.c | 28 +++---------------------
drivers/clk/tegra/clk-tegra124-dfll-fcpu.c | 16 ++------------
drivers/clk/ti/clk-dra7-atl.c | 20 +++--------------
15 files changed, 37 insertions(+), 227 deletions(-)


 \ /
  Last update: 2016-07-05 00:01    [W:0.165 / U:24.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site