[lkml]   [2016]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] vfs: fix typo in link_path_walk()
On Mon, Jul 04, 2016 at 05:48:53PM +0100, Luis de Bethencourt wrote:
> Comment documenting the path parsing in link_path_walk() has a typo, fixing
> it.

> @@ -2064,7 +2064,7 @@ static int link_path_walk(const char *name, struct nameidata *nd)
> if (!*name)
> goto OK;
> /*
> - * If it wasn't NUL, we know it was '/'. Skip that
> + * If it wasn't NULL, we know it was '/'. Skip that

"If it wasn't <this>, we know it was <that>" really implies that <this> and
<that> are values possible for the same expression, doesn't it? How could
a pointer (NULL) and a character ('/') possibly be such?

Could you explain the meaning of thus "fixed" comment? I'm not even asking
to explain why it is correct that way, just what the hell is it supposed to

NAK, in case it's not obvious from the above...

 \ /
  Last update: 2016-07-04 23:21    [W:0.028 / U:29.764 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site