lkml.org 
[lkml]   [2016]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [RFC PATCH v2 2/4] net: ethernet: xilinx: Add gmii2rgmii converter support
Date
Hi Nicolas,


> >
> > #ifdef CONFIG_NET_VENDOR_XILINX
>
> You may need to have:
> #if defined(CONFIG_NET_VENDOR_XILINX) &&
> defined(CONFIG_XILINX_GMII2RGMII)
>
> > extern int gmii2rgmii_phyprobe(struct gmii2rgmii *xphy); #else extern
> > void gmii2rgmii_phyprobe(struct gmii2rgmii *xphy);
>
> No need for the line above...
>
> > void gmii2rgmii_phyprobe(struct gmii2rgmii *xphy) { }
>
> On one single line, like:
>
> static inline void gmii2rgmii_phyprobe(struct gmii2rgmii *xphy) { }
>
> > #endif
> > For me the changes are looking odd...
>
> For me, it's okay...

Ok will fix as you suggested...

>
> >
> > Other possible ways
> > 1) Put a config check around phyprobe api in the macb driver.
> > #ifdef CONFIG_XILINX_GMII2RGMII
> > gmii2rgmii_phyprobe(&bp->converter_phy);
> > #endif
>
> Nope!
>
> > 2) Select NET_VENDOR_XILINX in the macb Kconfig @ -22,6 +22,7 @@
> > config MACB
> > tristate "Cadence MACB/GEM support"
> > depends on HAS_DMA
> > select PHYLIB
> > + select NET_VENDOR_XILINX
>
>
>
> > Please let me know which one you prefer will fix that and will post v3...
>
> First one with my changes is the best. But maybe wait for more feedback...

Ok sure will wait and will post next version with your suggestion in case of no comments...

Regards,
Kedar.

>
> Bye,
> --
> Nicolas Ferre

\
 
 \ /
  Last update: 2016-07-04 15:21    [W:0.049 / U:2.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site