lkml.org 
[lkml]   [2016]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 4/7] bus: arm-cci: add missing of_node_put after calling of_parse_phandle
Date

>
>On Fri, Jul 01, 2016 at 11:29:58AM +0100, Suzuki K Poulose wrote:
>> On 01/07/16 10:41, Peter Chen wrote:
>> >of_node_put needs to be called when the device node which is got from
>> >of_parse_phandle has finished using.
>> >
>> >Cc: Will Deacon <will.deacon@arm.com>
>> >Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
>> >Signed-off-by: Peter Chen <peter.chen@nxp.com>
>>
>> Thanks for the fix.
>>
>> >---
>> > drivers/bus/arm-cci.c | 5 ++++-
>> > 1 file changed, 4 insertions(+), 1 deletion(-)
>> >
>> >diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c index
>> >a49b283..e7b0b8c 100644
>> >--- a/drivers/bus/arm-cci.c
>> >+++ b/drivers/bus/arm-cci.c
>> >@@ -1912,9 +1912,12 @@ static int __cci_ace_get_port(struct device_node *dn,
>int type)
>> > cci_portn = of_parse_phandle(dn, "cci-control-port", 0);
>> > for (i = 0; i < nb_cci_ports; i++) {
>> > ace_match = ports[i].type == type;
>> >- if (ace_match && cci_portn == ports[i].dn)
>> >+ if (ace_match && cci_portn == ports[i].dn) {
>> >+ of_node_put(cci_portn);
>> > return i;
>> >+ }
>> > }
>> >+ of_node_put(cci_portn);
>>
>> nit: Could we please do some thing like this ?
>> if (ace_match && cci_portn == ports[i].dn)
>> break;
>> }
>>
>> of_node_put(cci_portn);
>> return (i < nb_cci_ports) ? i : -ENODEV ;
>>
>> Either way,
>>
>> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>
>Please route this via arm-soc once you've addressed Suzuki's comment.
>

Hi Will, how to route patch via arm-soc?

Does it mean sending patch by adding arm@kernel.org at To or Cc list?

Peter

\
 
 \ /
  Last update: 2016-07-04 14:01    [W:0.133 / U:12.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site