lkml.org 
[lkml]   [2016]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] checkkconfigsymbols.py: add --no-color option
Hi Andrew,

thanks for your patch. Please remove the colour comment from the commit
message and resend the patch. Such comments are better below the '---'.

On Jul 04 '16 18:39, Andrew Donnellan wrote:
> Add a new option, --no-color, to get rid of ANSI colour escape codes in the
> output. Useful if redirecting output to a file or piping to another script.
>
> (It should really be --no-colour, but I'll accept US spelling in the name
> of consistency with existing usage in the code comments...)
>
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>

Acked-by: Valentin Rothberg <valentinrothberg@gmail.com>

Thanks,
Valentin
> ---
> scripts/checkkconfigsymbols.py | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/checkkconfigsymbols.py b/scripts/checkkconfigsymbols.py
> index df643f6..a9eba02 100755
> --- a/scripts/checkkconfigsymbols.py
> +++ b/scripts/checkkconfigsymbols.py
> @@ -82,6 +82,10 @@ def parse_options():
> default=False,
> help="Reset current Git tree even when it's dirty.")
>
> + parser.add_option('', '--no-color', dest='no_color', action='store_true',
> + default=False,
> + help="Don't print colored output.")
> +
> (opts, _) = parser.parse_args()
>
> if opts.commit and opts.diff:
> @@ -116,6 +120,9 @@ def main():
> """Main function of this module."""
> opts = parse_options()
>
> + global no_color
> + no_color = opts.no_color
> +
> if opts.sim and not opts.commit and not opts.diff:
> sims = find_sims(opts.sim, opts.ignore)
> if sims:
> @@ -202,14 +209,14 @@ def yel(string):
> """
> Color %string yellow.
> """
> - return "\033[33m%s\033[0m" % string
> + return string if no_color else "\033[33m%s\033[0m" % string
>
>
> def red(string):
> """
> Color %string red.
> """
> - return "\033[31m%s\033[0m" % string
> + return string if no_color else "\033[31m%s\033[0m" % string
>
>
> def execute(cmd):
> --
> Andrew Donnellan OzLabs, ADL Canberra
> andrew.donnellan@au1.ibm.com IBM Australia Limited
>

\
 
 \ /
  Last update: 2016-07-04 13:21    [W:0.087 / U:6.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site